-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ca-certificates: for accessing remote raster files; #311
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should ca-certificats package be removed from master template? or maybe i'm just looking at the changes incorrect?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe i'm missing it, but in the master tenmplates it seems in cases where the ca-certificates package is not found to be installed, there's no explicit installation. I'm not understanding the reason for the removal of the explicit ca-certificates package from the master templates.
this is the "original" Dockerifle.master.templete ... ( search for 'ca-certificates' ) this is the proposed "new" Dockerfile.master.template: And the 'ca-certificates' is installed in both of the "stage" ( we are using "multi-stage builds" )
in my proposal:
|
oops, I see now. I was definitely reading incorrectly 😅 looks good and thanks for the clarifications! |
fix: #307
important changes:
Dockerfile.template
Dockerfile.alpine.template
Dockerfile.master.template
based on my local test; minimal disk space increase is expected ( < 1MB )
disclaimer: remote raster file access not tested;
IMHO: if the CI/CD is OK then ready to review/merge.