Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ca-certificates: for accessing remote raster files; #311

Merged
merged 3 commits into from
Sep 4, 2022

Conversation

ImreSamu
Copy link
Member

@ImreSamu ImreSamu commented Sep 2, 2022

fix: #307

important changes:

  • Dockerfile.template
  • Dockerfile.alpine.template
  • Dockerfile.master.template

based on my local test; minimal disk space increase is expected ( < 1MB )

# debian
new_postgis                                       14-3.2               77ce6bebee3d   20 seconds ago   575MB
postgis/postgis                                   14-3.2               9791b51b1ff7   4 days ago       575MB

# alpine
new_postgis                                       14-3.2-alpine        c18a9d1d4d26   3 minutes ago    395MB
postgis/postgis                                   14-3.2-alpine        128949707ecd   4 days ago       395MB

# master  - not tested .. disk space is less important.

disclaimer: remote raster file access not tested;

IMHO: if the CI/CD is OK then ready to review/merge.

Copy link
Contributor

@phillipross phillipross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should ca-certificats package be removed from master template? or maybe i'm just looking at the changes incorrect?

13-master/Dockerfile Outdated Show resolved Hide resolved
14-master/Dockerfile Outdated Show resolved Hide resolved
15beta3-master/Dockerfile Outdated Show resolved Hide resolved
Dockerfile.master.template Outdated Show resolved Hide resolved
Copy link
Contributor

@phillipross phillipross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe i'm missing it, but in the master tenmplates it seems in cases where the ca-certificates package is not found to be installed, there's no explicit installation. I'm not understanding the reason for the removal of the explicit ca-certificates package from the master templates.

13-master/Dockerfile Show resolved Hide resolved
14-master/Dockerfile Show resolved Hide resolved
15beta3-master/Dockerfile Show resolved Hide resolved
Dockerfile.master.template Show resolved Hide resolved
@ImreSamu
Copy link
Member Author

ImreSamu commented Sep 3, 2022

maybe i'm missing it, but in the master tenmplates it seems in cases where the ca-certificates package is not found to be installed,
there's no explicit installation. I'm not understanding the reason for the removal
of the explicit ca-certificates package from the master templates.

this is the "original" Dockerifle.master.templete ... ( search for 'ca-certificates' )

this is the proposed "new" Dockerfile.master.template:

And the 'ca-certificates' is installed in both of the "stage" ( we are using "multi-stage builds" )

  • stage1: installed in L40 ( line 40 )
  • stage2: installed in L243
  • stage2: uninstalled in L303
    * I have removed this line from the new temple ... so we are keeping it.

in my proposal:
I have

  • removed the "stage2" uninstall ( L303 in the original template )
  • and added an "extra comment warning" + "extra package test"
    • .. for avoiding any non-perfect future refactoring.

@phillipross
Copy link
Contributor

oops, I see now. I was definitely reading incorrectly 😅 looks good and thanks for the clarifications!

@phillipross phillipross merged commit d2806db into postgis:master Sep 4, 2022
@ImreSamu ImreSamu deleted the add_certificates branch September 4, 2022 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot access remote raster files when querying raster ca-certificates missing
2 participants