Silence yacc warnings #516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Komzpa
approved these changes
Nov 16, 2019
Komzpa
approved these changes
Nov 16, 2019
| @@ -1,4 +1,4 @@ | |||
| /* A Bison parser, made by GNU Bison 3.4. */ | |||
| /* A Bison parser, made by GNU Bison 3.4.2. */ | |||
There was a problem hiding this comment.
Can we do something about not committing this file into repo? It looks completely generated, and seems to be going to be built anyway during build process.
There was a problem hiding this comment.
Unexpectedly I've been asking for this for a long time now. Contrary argument has always been: not everyone can easily get a parser generator nowadays ... Please please let's get rid of it now!
There was a problem hiding this comment.
I'd be ok with it. We just need to make sure it can also be generated with the tarball releases.
|
I'd be ok with it. We just need to make sure it can also be generated with the tarball releases.
Yes, make_dist.sh would need a tweak to fix that.
The "distclean" rule should be already NOT removing that file.
|
|
I've created a different issue to handle the file removal (https://trac.osgeo.org/postgis/ticket/4584) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting tired of them.
Fixes https://trac.osgeo.org/postgis/ticket/4473 but it