Minor correction in docs for LDAP_SEARCH_SCOPE #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://github.com/postgres/pgadmin4/blob/102ffd141c92d8c1ada72c42e86fb9be6260dfe1/web/config.py#L606 the values should be BASE, LEVEL or SUBTREE. Tested for "subtree": "Error searching the LDAP directory: invalid scope type" By contrast, "SUBTREE" works as expected.
|
Thanks for your Pull Request! 😄 This repo on GitHub is just a mirror of our real git repositories though, and can't really handle PRs. 😦 Hopefully you can redo the PR, and direct it to the git.postgresql.org repos? We have a developer guide, if that helps: https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F. If this was a PR for pgAdmin, please visit https://www.pgadmin.org/docs/pgadmin4/dev/submitting_patches.html, or if it was a patch for pgweb, please send it to pgsql-www@lists.postgresql.org. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://github.com/postgres/pgadmin4/blob/102ffd141c92d8c1ada72c42e86fb9be6260dfe1/web/config.py#L606 the values should be BASE, LEVEL or SUBTREE.
Tested for "subtree": "Error searching the LDAP directory: invalid scope type"
By contrast, "SUBTREE" works as expected.