Skip to content

Commit

Permalink
Postpone calls of unsafe server-side functions in pg_dump.
Browse files Browse the repository at this point in the history
Avoid calling pg_get_partkeydef(), pg_get_expr(relpartbound),
and regtypeout until we have lock on the relevant tables.
The existing coding is at serious risk of failure if there
are any concurrent DROP TABLE commands going on --- including
drops of other sessions' temp tables.

Back-patch of commit e3fcbbd.  That's been in v15/HEAD long enough
to have some confidence about it, so now let's fix the problem in
older branches.

Original patch by me; thanks to Gilles Darold for back-patching
legwork.

Discussion: https://postgr.es/m/2273648.1634764485@sss.pgh.pa.us
Discussion: https://postgr.es/m/7d7eb6128f40401d81b3b7a898b6b4de@W2012-02.nidsa.loc
Discussion: https://postgr.es/m/45c93d57-9973-248e-d2df-e02ca9af48d4@darold.net
  • Loading branch information
tglsfdc committed Nov 19, 2022
1 parent 038512f commit 55f30e6
Show file tree
Hide file tree
Showing 2 changed files with 79 additions and 71 deletions.

0 comments on commit 55f30e6

Please sign in to comment.