redo/undo support functions and cleanups.

src/backend/access/nbtree/nbtree.c

@@ -12,7 +12,7 @@
  * Portions Copyright (c) 1994, Regents of the University of California
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtree.c,v 1.65 2000/10/13 12:05:20 vadim Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtree.c,v 1.66 2000/10/20 11:01:03 vadim Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -1261,44 +1261,40 @@ _bt_del_item(Relation reln, Buffer buffer, BTItem btitem, bool insert,
 	}
 
 	lp = PageGetItemId(page, offno);
-	if (ItemIdDeleted(lp))	/* marked for deletion */
-	{
-		if (!InRecovery)
-			elog(STOP, "btree_%s_undo: deleted target tuple in rollback",
-				(insert) ? "insert" : "split");
-	}
-	else if (InRecovery)	/* check heap tuple */
+
+	if (InRecovery)					/* check heap tuple */
 	{
-		int			result;
-		CommandId	cid;
-		RelFileNode	hnode;
-		Size		hsize = (insert) ? SizeOfBtreeInsert : SizeOfBtreeSplit;
-
-		memcpy(&cid, (char*)xlrec + hsize, sizeof(CommandId));
-		memcpy(&hnode, (char*)xlrec + hsize + sizeof(CommandId), sizeof(RelFileNode));
-		result = XLogIsOwnerOfTuple(hnode, &(btitem->bti_itup.t_tid),
-					record->xl_xid, cid);
-		if (result < 0)	/* not owner */
+		if (!ItemIdDeleted(lp))
 		{
-			UnlockAndReleaseBuffer(buffer);
-			return;
-		}
-	}
-	else if (! BufferIsUpdatable(buffer))	/* normal rollback */
-	{
-		lp->lp_flags |= LP_DELETE;
-		MarkBufferForCleanup(buffer, IndexPageCleanup);
-		return;
-	}
+			int			result;
+			CommandId	cid;
+			RelFileNode	hnode;
+			Size		hsize = (insert) ? SizeOfBtreeInsert : SizeOfBtreeSplit;
 
-	PageIndexTupleDelete(page, offno);
-	if (InRecovery)
-	{
+			memcpy(&cid, (char*)xlrec + hsize, sizeof(CommandId));
+			memcpy(&hnode, (char*)xlrec + hsize + sizeof(CommandId), sizeof(RelFileNode));
+			result = XLogIsOwnerOfTuple(hnode, &(btitem->bti_itup.t_tid),
+						record->xl_xid, cid);
+			if (result < 0)	/* not owner */
+			{
+				UnlockAndReleaseBuffer(buffer);
+				return;
+			}
+		}
+		PageIndexTupleDelete(page, offno);
 		pageop = (BTPageOpaque) PageGetSpecialPointer(page);
 		pageop->btpo_flags |= BTP_REORDER;
+		UnlockAndWriteBuffer(buffer);
+		return;
 	}
-	UnlockAndWriteBuffer(buffer);
 
+	/* normal rollback */
+	if (ItemIdDeleted(lp))	/* marked for deletion ?! */
+		elog(STOP, "btree_%s_undo: deleted target tuple in rollback",
+			(insert) ? "insert" : "split");
+
+	lp->lp_flags |= LP_DELETE;
+	MarkBufferForCleanup(buffer, IndexPageCleanup);
 	return;
 }
 

src/backend/access/transam/xact.c

@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.72 2000/10/11 21:28:17 momjian Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/access/transam/xact.c,v 1.73 2000/10/20 11:01:04 vadim Exp $
  *
  * NOTES
  *		Transaction aborts can now occur two ways:
@@ -154,6 +154,8 @@
  */
 #include "postgres.h"
 
+#include <sys/time.h>
+
 #include "access/nbtree.h"
 #include "catalog/heap.h"
 #include "catalog/index.h"
@@ -215,6 +217,19 @@ TransactionState CurrentTransactionState = &CurrentTransactionStateData;
 int			DefaultXactIsoLevel = XACT_READ_COMMITTED;
 int			XactIsoLevel;
 
+#ifdef XLOG
+#include "access/xlogutils.h"
+
+int			CommitDelay;
+
+void		xact_redo(XLogRecPtr lsn, XLogRecord *record);
+void		xact_undo(XLogRecPtr lsn, XLogRecord *record);
+
+static void (*_RollbackFunc)(void*) = NULL;
+static void *_RollbackData = NULL;
+
+#endif
+
 /* ----------------
  *		info returned when the system is disabled
  *
@@ -676,6 +691,28 @@ RecordTransactionCommit()
 		 */
 		TransactionIdCommit(xid);
 
+#ifdef XLOG
+		{
+			xl_xact_commit	xlrec;
+			struct timeval	delay;
+			XLogRecPtr		recptr;
+
+			xlrec.xtime = time(NULL);
+			/*
+			 * MUST SAVE ARRAY OF RELFILENODE-s TO DROP
+			 */
+			recptr = XLogInsert(RM_XACT_ID, XLOG_XACT_COMMIT,
+				(char*) &xlrec, SizeOfXactCommit, NULL, 0);
+
+			/* 
+			 * Sleep before commit! So we can flush more than one
+			 * commit records per single fsync.
+			 */
+			delay.tv_sec = 0;
+			delay.tv_usec = CommitDelay;
+			(void) select(0, NULL, NULL, NULL, &delay);
+		}
+#endif
 		/*
 		 * Now write the log info to the disk too.
 		 */
@@ -785,6 +822,18 @@ RecordTransactionAbort()
 	if (SharedBufferChanged && !TransactionIdDidCommit(xid))
 		TransactionIdAbort(xid);
 
+#ifdef XLOG
+	if (SharedBufferChanged)
+	{
+		xl_xact_abort	xlrec;
+		XLogRecPtr		recptr;
+
+		xlrec.xtime = time(NULL);
+		recptr = XLogInsert(RM_XACT_ID, XLOG_XACT_ABORT,
+			(char*) &xlrec, SizeOfXactAbort, NULL, 0);
+	}
+#endif
+
 	/*
 	 * Tell bufmgr and smgr to release resources.
 	 */
@@ -1123,10 +1172,13 @@ AbortTransaction()
 	AtEOXact_SPI();
 	AtEOXact_nbtree();
 	AtAbort_Cache();
-	AtAbort_Locks();
 	AtAbort_Memory();
 	AtEOXact_Files();
 
+	/* Here we'll rollback xaction changes */
+
+	AtAbort_Locks();
+
 	SharedBufferChanged = false; /* safest place to do it */
 
 	/* ----------------
@@ -1663,3 +1715,54 @@ IsTransactionBlock()
 
 	return false;
 }
+
+#ifdef XLOG
+
+void
+xact_redo(XLogRecPtr lsn, XLogRecord *record)
+{
+	uint8	info = record->xl_info & ~XLR_INFO_MASK;
+
+	if (info == XLOG_XACT_COMMIT)
+	{
+		xl_xact_commit	*xlrec = (xl_xact_commit*) XLogRecGetData(record);
+
+		XLogMarkCommitted(record->xl_xid);
+		/* MUST REMOVE FILES OF ALL DROPPED RELATIONS */
+	}
+	else if (info == XLOG_XACT_ABORT)
+	{
+		XLogMarkAborted(record->xl_xid);
+	}
+	else
+		elog(STOP, "xact_redo: unknown op code %u", info);
+}
+
+void
+xact_undo(XLogRecPtr lsn, XLogRecord *record)
+{
+	uint8	info = record->xl_info & ~XLR_INFO_MASK;
+
+	if (info == XLOG_XACT_COMMIT)	/* shouldn't be called by XLOG */
+		elog(STOP, "xact_undo: can't undo committed xaction");
+	else if (info != XLOG_XACT_ABORT)
+		elog(STOP, "xact_redo: unknown op code %u", info);
+}
+
+void
+XactPushRollback(void (*func) (void *), void* data)
+{
+	if (_RollbackFunc != NULL)
+		elog(STOP, "XactPushRollback: already installed");
+
+	_RollbackFunc = func;
+	_RollbackData = data;
+}
+
+void
+XactPopRollback(void)
+{
+	_RollbackFunc = NULL;
+}
+
+#endif

src/backend/access/transam/xlog.c

@@ -6,7 +6,7 @@
  * Portions Copyright (c) 1996-2000, PostgreSQL, Inc
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.17 2000/07/04 01:49:43 vadim Exp $
+ * $Header: /cvsroot/pgsql/src/backend/access/transam/xlog.c,v 1.18 2000/10/20 11:01:04 vadim Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -40,6 +40,7 @@ char		ControlFilePath[MAXPGPATH];
 uint32		XLOGbuffers = 0;
 XLogRecPtr	MyLastRecPtr = {0, 0};
 bool		StopIfError = false;
+bool		InRecovery = false;
 
 SPINLOCK	ControlFileLockId;
 SPINLOCK	XidGenLockId;
@@ -163,17 +164,6 @@ typedef struct CheckPoint
 #define NextBufIdx(curridx)		\
 		((curridx == XLogCtl->XLogCacheBlck) ? 0 : (curridx + 1))
 
-#define XLByteLT(left, right)		\
-			(right.xlogid > left.xlogid || \
-			(right.xlogid == left.xlogid && right.xrecoff > left.xrecoff))
-
-#define XLByteLE(left, right)		\
-			(right.xlogid > left.xlogid || \
-			(right.xlogid == left.xlogid && right.xrecoff >=  left.xrecoff))
-
-#define XLByteEQ(left, right)		\
-			(right.xlogid == left.xlogid && right.xrecoff ==  left.xrecoff)
-
 #define InitXLBuffer(curridx)	(\
 				XLogCtl->xlblocks[curridx].xrecoff = \
 				(XLogCtl->xlblocks[Insert->curridx].xrecoff == XLogFileSize) ? \