Skip to content

Commit

Permalink
bufmgr: Acquire and clean victim buffer separately
Browse files Browse the repository at this point in the history
Previously we held buffer locks for two buffer mapping partitions at the same
time to change the identity of buffers.  Particularly for extending relations
needing to hold the extension lock while acquiring a victim buffer is
painful.But it also creates a bottleneck for workloads that just involve
reads.

Now we instead first acquire a victim buffer and write it out, if
necessary. Then we remove that buffer from the old partition with just the old
partition's partition lock held and insert it into the new partition with just
that partition's lock held.

By separating out the victim buffer acquisition, future commits will be able
to change relation extensions to scale better.

On my workstation, a micro-benchmark exercising buffered reads strenuously and
under a lot of concurrency, sees a >2x improvement.

Reviewed-by: Heikki Linnakangas <hlinnaka@iki.fi>
Reviewed-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/20221029025420.eplyow6k7tgu6he3@awork3.anarazel.de
  • Loading branch information
anarazel committed Apr 5, 2023
1 parent 65eb2d0 commit dad50f6
Show file tree
Hide file tree
Showing 2 changed files with 369 additions and 304 deletions.

0 comments on commit dad50f6

Please sign in to comment.