Rewrite archive.c in Rust #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use cross-platform path Remove C code Fun! alright no warnings keep c code as reference Put archive back for reference Fixes Checks add space bakc
levkk
force-pushed
the
levkk-fe-utils-archive-rust
branch
from
f85b52b
to
4ed66b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust Proof of Concept
PoC rewrite of
fe_utils/archive.candcommon/archive.cin Rust. I picked these because they were relatively simple single function files. Multi-function files are possible as well, but will require deleting C code and replacing it with Rust instead of just object file swaps.Limitations
cargoand the Rust compiler don't support compiling the same project with multiple features at the same time, so just for now, usemake -j1when compiling. I think the fix for this would be to split the parts of Postgres into their own crates and share them (workspace).