should be ok not 400 #1251
should be ok not 400 #1251
Conversation
chillenberger
commented
Dec 20, 2023
chillenberger
commented
- Change test after changing behavior of docs bad path.
| @@ -550,7 +550,7 @@ This is the end of the markdown | |||
| let rsp = req.dispatch().await; | |||
|
|
|||
| assert!( | |||
| rsp.status() == Status::NotFound, | |||
| rsp.status() == Status::Ok, | |||
There was a problem hiding this comment.
Should be 404 when doc not found. If we return ok, google will index the not found page and real and pollute the search index.
There was a problem hiding this comment.
Ok, I can switch it back. We will have to wait on keeping the lefthand nav on bad path then.
There was a problem hiding this comment.
I don't understand what the connection between this and the leftnav is with the current context.
There was a problem hiding this comment.
After a bad path Montana would like the other docs there on the left so the user can easy navigate away from the 404 response.
There was a problem hiding this comment.
Ah I see, you'll just need a custom 404 page for the docs instead of using the default one. You can set that up with a 404 catcher in rocket.
