Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dan doc landing page #1320

Merged
merged 29 commits into from
Feb 20, 2024
Merged

Dan doc landing page #1320

merged 29 commits into from
Feb 20, 2024

Conversation

chillenberger
Copy link
Contributor

  • Create Docs landing page
  • New Docs article page
  • Change look of scrollbar
  • Remove index from careers and blogs
  • Redesigen TOC

@montanalow
Copy link
Contributor

Now that we're indexing all docs/blogs premptively, is it easy to build the index page urls without the trailing /? The reason I added that / in the first place was to prevent having to check on disk if it was a file or directory before appending the README.md name. If we can avoid the extra check now, it'd be nice to be consistent.

@chillenberger
Copy link
Contributor Author

Now that we're indexing all docs/blogs premptively, is it easy to build the index page urls without the trailing /? The reason I added that / in the first place was to prevent having to check on disk if it was a file or directory before appending the README.md name. If we can avoid the extra check now, it'd be nice to be consistent.

When the user navigates to a doc url we still use the url path to build the file path in the get_content_path method. We can't get away from the check now. We could do what your asking, but it's not trivial enough to throw into this PR.

@chillenberger chillenberger merged commit b444b82 into master Feb 20, 2024
1 check passed
@chillenberger chillenberger deleted the dan-doc-landing-page branch February 20, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants