Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested components #975

Merged
merged 11 commits into from
Sep 3, 2023
Merged

Nested components #975

merged 11 commits into from
Sep 3, 2023

Conversation

levkk
Copy link
Contributor

@levkk levkk commented Sep 2, 2023

pgml-components

Nested components

Add support for creating components in subfolders of src/components. This allows grouping components together, e.g.:

cargo pgml-components add component controls/button
cargo pgml-components add component controls/dropdown
cargo pgml-components add component popups/modal
cargo pgml-components add component popups/tooltip

created directory src/components/controls/button
written src/components/controls/button/template.html
written src/components/controls/button/button_controller.js
written src/components/controls/button/mod.rs
written src/components/controls/button/button.scss
written src/components/controls/mod.rs
written src/components/mod.rs
created directory src/components/controls/dropdown
written src/components/controls/dropdown/template.html
written src/components/controls/dropdown/dropdown_controller.js
written src/components/controls/dropdown/mod.rs
written src/components/controls/dropdown/dropdown.scss
written src/components/controls/mod.rs
created directory src/components/popups/modal
written src/components/popups/modal/template.html
written src/components/popups/modal/modal_controller.js
written src/components/popups/modal/mod.rs
written src/components/popups/modal/modal.scss
written src/components/popups/mod.rs
written src/components/mod.rs
created directory src/components/popups/tooltip
written src/components/popups/tooltip/template.html
written src/components/popups/tooltip/tooltip_controller.js
written src/components/popups/tooltip/mod.rs
written src/components/popups/tooltip/tooltip.scss
written src/components/popups/mod.rs

Bug fixes

  1. Prevents using Rust-reserved keywords in component names.
  2. Makes sure components can be created in their own folders only without breaking other components.

Misc

  1. Add more default code into the component templates to make them easier to find when added for the first time into the DOM.
    image

Tests

Added a few tests to cover basic use cases and help with regressions.

pgml-dashboard

  1. Added back dev-mode that reads from style.css and bundle.js instead of from the hashed files. This allows to not rebuild the app every time JS or CSS changes are made.

@levkk levkk marked this pull request as ready for review September 3, 2023 22:21
@levkk levkk merged commit f8a1c4a into master Sep 3, 2023
1 check passed
@levkk levkk deleted the levkk-commit-tool branch September 3, 2023 22:23
SilasMarvin pushed a commit that referenced this pull request Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant