Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s v1.22 compatibility #117

Closed
tiina303 opened this issue Sep 14, 2021 · 3 comments · Fixed by #122 or #126
Closed

K8s v1.22 compatibility #117

tiina303 opened this issue Sep 14, 2021 · 3 comments · Fixed by #122 or #126
Assignees

Comments

@tiina303
Copy link
Contributor

we use v1beta1 quite a bit & it's not available going forward
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122

@tiina303
Copy link
Contributor Author

We only need to change

  1. ingress.yaml for networking.k8s.io/v1beta1
  2. clickhouse crds for apiextensions.k8s.io/v1beta1

Note that the frontend config is networking.gke not k8s which isn't getting deprecated yet and is still used in various docs e.g. https://cloud.google.com/kubernetes-engine/docs/how-to/ingress-features#1.16-gke.3+_1

based on

$ grep "/v1beta1" -r charts/posthog
charts/posthog/crds/clickhouse_installation_template.yaml:apiVersion: apiextensions.k8s.io/v1beta1
charts/posthog/crds/clickhouse_operator_configurations.yaml:apiVersion: apiextensions.k8s.io/v1beta1
charts/posthog/crds/clickhouse_installation.yaml:apiVersion: apiextensions.k8s.io/v1beta1
charts/posthog/templates/gce-frontend-config.yaml:apiVersion: networking.gke.io/v1beta1
charts/posthog/templates/ingress.yaml:apiVersion: networking.k8s.io/v1beta1
charts/posthog/templates/ingress.yaml:    networking.gke.io/v1beta1.FrontendConfig: "{{ .Release.Name }}-frontend-config"

@tiina303
Copy link
Contributor Author

TODO: add a 1.22 test to the ci as well

@fuziontech fuziontech linked a pull request Sep 15, 2021 that will close this issue
@tiina303
Copy link
Contributor Author

tiina303 commented Sep 15, 2021

Based on the earlier grep (no more v1beta1's) the good news is we're going to be k8s 1.25 compatible (as of now, I'm sure they will add more stuff there) after these changes as we don't have anything that will be deprecated there https://kubernetes.io/docs/reference/using-api/deprecation-guide/#v1-25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant