Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for helm releases with a different name #206

Open
taobojlen opened this issue Nov 26, 2021 · 3 comments
Open

Improved support for helm releases with a different name #206

taobojlen opened this issue Nov 26, 2021 · 3 comments
Labels
enhancement New feature or request helm Helm chart work P2 nice to have

Comments

@taobojlen
Copy link

Proposed change

When deploying to a name other than posthog, e.g. my-posthog-deployment, we had to add the following config:

  kafka:
    externalZookeeper:
      servers:
        - "my-posthog-deployment-posthog-zookeeper:2181"

It would be nice if this was handled automatically.

Alternative options

Perhaps just some documentation would be helpful; it took a little while to debug this.

Additional context

@taobojlen taobojlen added the enhancement New feature or request label Nov 26, 2021
@guidoiaquinti
Copy link
Contributor

👋 Hi Tao,
thank you for opening this issue! What do you mean with deploying to a name other than posthog? The Helm release name?

@taobojlen
Copy link
Author

Yes, sorry, that's correct! The Helm release name.

@taobojlen taobojlen changed the title Improved support for deployments with a different name Improved support for helm releases with a different name Nov 26, 2021
@tiina303
Copy link
Contributor

We should likely just improve that by in the chart/values rather than docs.

- posthog-posthog-zookeeper:2181
is where the posthog release name is implied from

@fuziontech fuziontech added helm Helm chart work P2 nice to have labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request helm Helm chart work P2 nice to have
Projects
None yet
Development

No branches or pull requests

4 participants