Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speed up cohorts and use antd #706

Merged
merged 4 commits into from May 4, 2020
Merged

Speed up cohorts and use antd #706

merged 4 commits into from May 4, 2020

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Apr 30, 2020

Changes

  • Don't show the last event of each user, bringing the speed of the /people pages from ~7 seconds to 0.5
  • Redo table etc in antd

Notes:

  • When QA-ing make sure to also check clicking on /trends in graph

Checklist

  • All querysets/queries filter by Team (if applicable)
  • Backend tests (if applicable)

@timgl timgl temporarily deployed to posthog-speed-up-cohort-l87fwl April 30, 2020 21:31 Inactive
EDsCODE
EDsCODE requested changes May 4, 2020
View reviewed changes
Copy link
Member

@EDsCODE EDsCODE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the csv function merged and the export works! Otherwise, found a few bugs and suggested fixes

frontend/src/scenes/users/People.js Outdated Show resolved Hide resolved
frontend/src/scenes/users/PeopleTable.js Outdated Show resolved Hide resolved
frontend/src/scenes/users/PeopleTable.js Outdated Show resolved Hide resolved
frontend/src/scenes/users/PeopleTable.js Outdated Show resolved Hide resolved
@timgl timgl force-pushed the speed-up-cohorts-and-antd branch from 69aad12 to e2f225c Compare May 4, 2020 16:38
@timgl
Copy link
Collaborator Author

timgl commented May 4, 2020

Thanks, all fixed now!

@timgl timgl temporarily deployed to posthog-speed-up-cohort-l87fwl May 4, 2020 16:39 Inactive
@EDsCODE
Copy link
Member

EDsCODE commented May 4, 2020

Adjustments work! One more thing I found that may seems to have surfaced is now when deleting a user it doesn't auto refresh as it did previously

@timgl
Copy link
Collaborator Author

timgl commented May 4, 2020

Sorry, fixed!

@timgl timgl temporarily deployed to posthog-speed-up-cohort-l87fwl May 4, 2020 17:01 Inactive
@EDsCODE EDsCODE self-requested a review May 4, 2020 17:43
@timgl timgl merged commit 1647406 into master May 4, 2020
@timgl timgl deleted the speed-up-cohorts-and-antd branch May 4, 2020 17:44
@EDsCODE EDsCODE mentioned this pull request May 12, 2020
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timgl @EDsCODE