Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript definitions #201

Closed
metonym opened this issue Jul 19, 2022 · 1 comment · Fixed by #203
Closed

TypeScript definitions #201

metonym opened this issue Jul 19, 2022 · 1 comment · Fixed by #203

Comments

@metonym
Copy link
Contributor

metonym commented Jul 19, 2022

It would be useful to have TypeScript definitions when using the library programmatically with Node/TypeScript.

Would you be receptive to a PR that adds types? As an alternative, I'd be happy to contribute them to https://github.com/DefinitelyTyped/DefinitelyTyped as @types/htmlnano if it's beyond the scope of this project.
@maltsev
Copy link
Member

maltsev commented Jul 21, 2022

Yes, I'd be happy to accept your PR. Thanks!

metonym added a commit to metonym/htmlnano that referenced this issue Jul 29, 2022
@metonym
Add TypeScript definitions
ab5a39d 
Closes posthtml#201
@metonym metonym mentioned this issue Jul 29, 2022
Merged
@SukkaW SukkaW mentioned this issue Aug 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add TypeScript definitions metonym/htmlnano
2 participants
@maltsev @metonym