Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peerDependencies #253

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Update peerDependencies #253

merged 1 commit into from
Apr 14, 2023

Conversation

shoonia
Copy link
Contributor

@shoonia shoonia commented Apr 14, 2023

Allow using cssnano@6.0.0.

When I try to use cssnano@6.0.0 in my package dependencies

  "dependencies": {
    ...
    "cssnano": "^6.0.0",
    ...
    "htmlnano": "^2.0.3",
    ...
  }

I see the following error in the console

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: htmlnano@2.0.3
npm ERR! Found: cssnano@6.0.0
npm ERR! node_modules/cssnano
npm ERR!   cssnano@"^6.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional cssnano@"^5.0.11" from htmlnano@2.0.3
npm ERR! node_modules/htmlnano
npm ERR!   htmlnano@"^2.0.3" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: cssnano@5.1.15
npm ERR! node_modules/cssnano
npm ERR!   peerOptional cssnano@"^5.0.11" from htmlnano@2.0.3
npm ERR!   node_modules/htmlnano
npm ERR!     htmlnano@"^2.0.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Allow using `cssnano` v6

```bash
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: htmlnano@2.0.3
npm ERR! Found: cssnano@6.0.0
npm ERR! node_modules/cssnano
npm ERR!   cssnano@"^6.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peerOptional cssnano@"^5.0.11" from htmlnano@2.0.3
npm ERR! node_modules/htmlnano
npm ERR!   htmlnano@"^2.0.3" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: cssnano@5.1.15
npm ERR! node_modules/cssnano
npm ERR!   peerOptional cssnano@"^5.0.11" from htmlnano@2.0.3
npm ERR!   node_modules/htmlnano
npm ERR!     htmlnano@"^2.0.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
```
@maltsev maltsev merged commit 1d05d12 into posthtml:master Apr 14, 2023
@maltsev
Copy link
Member

maltsev commented Apr 15, 2023

I released new version htmlnano@2.0.4

@shoonia shoonia deleted the patch-1 branch April 17, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants