feat: added newline formatting for comments

[anikethsaha]

fixes #250

Before

<a>as</a>
<!--   multi 
 line      -->

<!-- mm -->

<!-- 
  on
-->

After

<a>as</a>
<!-- 
    multi 
 line       
 -->

<!-- mm -->

<!-- on -->

[Scrum]

What do you think about making this functionality an option?

[Scrum]

1. Regular expression /<!--[^]*-->/gm is better to put in a constant
2. The beginning <!-- and the end --> of the notation for the comment I would put into a constant

[anikethsaha]

yea cool 👍

[anikethsaha]

2. The beginning <!-- and the end --> of the notation for the comment I would put into a constant

DOne 👍

1. Regular expression /<!--[^]*-->/gm is better to put in a constant

I dont know why but when I am putting that into a constant and using the .test method, its not working.

[Scrum]

you create with new RegExp ?

[anikethsaha]

I tried, its still the same. I don't know why it's happening. Its working fine for the other regex constants

[Scrum]

hmm yes that's weird

[Scrum]

Here, it seems to me that a regular expression that takes into account a multiline is better - <!--([\s\S]*?)--> content will match

[anikethsaha]

I will check this.

[anikethsaha]

done

[Scrum]

Pay attention to this post here is a coincidence and there will be our content, and we do not need to replace

[anikethsaha]

I didnt get this 🔼

[anikethsaha]

What do you think about making this functionality an option?

yea we can, can you suggest the option name ? may be formatComment ?

[Scrum]

yea we can, can you suggest the option name ? may be formatComment ?

I like it better when there is narrowness first and then its options, for example

commentTrim, commentFormat etc a good name on the run until you come up with))

[anikethsaha]

commentFormat sounds good

[anikethsaha]

about

node = node?.trim()

node won't be undefined, just that we need the type of the node to be string in order to do the trim,

I guess optional chaining doesnt work the type , it just checks the whether its undefined or not, right !.

Let me know if I missed anything.

[Scrum]

I guess optional chaining doesnt work the type , it just checks the whether its undefined or not, right !.

Yes, in this case only .trim()

[anikethsaha]

I guess optional chaining doesnt work the type , it just checks the whether its undefined or not, right !.

Yes, in this case only .trim()

but with node?.trim() it will try to trim the object type as well which will be an error as object doesnt have trim method.

[Scrum]

I guess optional chaining doesnt work the type , it just checks the whether its undefined or not, right !.

Yes, in this case only .trim()

but with node?.trim() it will try to trim the object type as well which will be an error as object doesnt have trim method.

Ohhh yes, I think I missed this little detail of the fact that the first condition is string checking

I think then it will be better if we put out the regular expression test in the condition

if (typeof(node) === 'string') {
  node = node.trim()
  if (...) {...}
}

[Scrum]

@anikethsaha Hi, reviewers please ))

[anikethsaha]

Looks good to me. 🎉

[Scrum]

@anikethsaha Good job, thanks