Milestone 1.0.0 #398
Open
Milestone 1.0.0 #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 617693e.
Scrum
requested review from
voischev,
mrmlnc and
michael-ciniawsky
as code owners
voischev
reviewed
Oct 31, 2023
| @@ -1,7 +1,8 @@ | |||
| [![NPM][npm]][npm-url] | |||
| [![Tests][build]][build-url] | |||
| [![Coverage][cover]][cover-url] | |||
| [![Standard Code Style][code-style]][code-style-url] | |||
|
|
|||
| [![Twitter][twitter]][twitter-url] | |||
There was a problem hiding this comment.
Можно удалить, все-равно никто не ведет канал
voischev
reviewed
Oct 31, 2023
| @@ -396,9 +397,7 @@ Thank you to all our backers! 🙏 [[Become a backer](https://opencollective.com | |||
| [cover]: https://coveralls.io/repos/posthtml/posthtml/badge.svg?branch=master | |||
| [cover-url]: https://coveralls.io/r/posthtml/posthtml?branch=master | |||
|
|
|||
| [code-style]: https://img.shields.io/badge/code%20style-standard-yellow.svg | |||
| [code-style-url]: http://standardjs.com/ | |||
There was a problem hiding this comment.
Не хочешь для v1 почистить readme от всяких лишних бейджиков и старых технологий?
There was a problem hiding this comment.
В планах, переписать readme )
voischev
reviewed
Oct 31, 2023
| @@ -1,145 +0,0 @@ | |||
| 'use strict' | |||
There was a problem hiding this comment.
А это через git mv? может сохраним историю, через мув а не через удаление?
There was a problem hiding this comment.
Есть мысли, что это не часть posthtml, и подключать их надо как расширение. На первых этапах все будет совместимо но с оповещением о выпиле. Так же добавлю в readme шаги для миграции.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.