New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide Docker option for setting up backend #110
Conversation
When running through the installation process with docker, I don't get the standard prompts to 1) replace my WP installation and 2) to create a new DB. Were these changes intentional? |
@prichey It was intentional as I was initially not running the installer with |
66a939f
to
24b754f
Compare
@prichey it'll ask now π |
1c9f10c
to
518905f
Compare
The |
No need to run |
Interesting, it looks like Docker cached the result of running that script. (Terminal output here). Wonder if it's worth throwing a |
Huh, even with https://gist.github.com/prichey/e8f283000967dfd95944f363066c8159 |
Works! LGTM |
- pass optional --docker flag to wordpress:setup that makes some minor adjustments to how the setup runs to accommodate Docker. Use localhost instead of 0.0.0.0 for the db ip since mysql can't connect to 0.0.0.0 within a Docker container. MySQL is installed as part of the Dockerfile so MySQL doesn't need to be installed during this part of the setup. - the wordpress server needs to bind to 0.0.0.0 in order for Docker port binding to work. - wp needs to be passed --allow-root since in our Docker container we're running everything as root.
This is fantastic, thank you so much @tristanoneil! |
π³β¨π³β¨π³β¨π³β¨π³β¨ π³β¨ π³β¨ π³β¨ π³β¨ π³β¨ π³β¨ π³β¨ π³β¨ π³
Many of the reported issues are caused by minor discrepancies across developers computers. Providing a Docker option should be more full proof in that we're starting with a known quantity (the base image). The commit message has a bit more detail explaining what's changed and why.