fix: filtering with an empty array as a value causes an error (#715)

* fix: filtering with an empty array as a value causes an error * fix: linter error * fix: remove code duplication * fix: Unnecessary 'else' after 'return' no-else-return linter error
postlight · Jul 11, 2017 · 6b3547f · 6b3547f · zacharygolba · Jul 11, 2017
1 parent 0f406b5
commit 6b3547f
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/packages/database/query/index.js b/src/packages/database/query/index.js
@@ -195,17 +195,17 @@ class Query<+T: any> extends Promise {
         }
 
         if (Array.isArray(value)) {
-          if (value.length > 1) {
-            this.snapshots.push([
-              not ? 'whereNotIn' : 'whereIn',
-              [key, value]
-            ]);
-          } else {
+          if (value.length === 1) {
             return {
               ...obj,
               [key]: value[0]
             };
           }
+
+          this.snapshots.push([
+            not ? 'whereNotIn' : 'whereIn',
+            [key, value]
+          ]);
         } else if (value === null) {
           this.snapshots.push([
             not ? 'whereNotNull' : 'whereNull',