fix: do not validate param existence for patch requests (#721)

postlight · Aug 28, 2017 · 6c22bdf · 6c22bdf
1 parent ea2b8f9
commit 6c22bdf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/src/packages/router/route/params/index.js b/src/packages/router/route/params/index.js
@@ -33,7 +33,7 @@ export function paramsFor({
     if (method === 'POST' || method === 'PATCH') {
       params = [
         ...params,
-        getDataParams(controller, true)
+        getDataParams(controller, method, true)
       ];
     }
   } else if (type === 'collection') {
@@ -45,7 +45,7 @@ export function paramsFor({
     if (method === 'POST' || method === 'PATCH') {
       params = [
         ...params,
-        getDataParams(controller, false)
+        getDataParams(controller, method, false)
       ];
     }
   } else if (type === 'custom') {

diff --git a/src/packages/router/route/params/utils/get-data-params.js b/src/packages/router/route/params/utils/get-data-params.js
@@ -41,17 +41,18 @@ function getTypeParam({
 /**
  * @private
  */
-function getAttributesParam({
-  model,
-  params
-}: Controller): [string, ParameterLike] {
+function getAttributesParam(
+  { model, params }: Controller,
+  method: 'PATCH' | 'POST',
+): [string, ParameterLike] {
   return ['attributes', new ParameterGroup(params.reduce((group, param) => {
     const col = model.columnFor(param);
 
     if (col) {
       const type = typeForColumn(col);
       const path = `data.attributes.${param}`;
-      const required = !col.nullable && isNull(col.defaultValue);
+      const required =
+        method !== 'PATCH' && !col.nullable && isNull(col.defaultValue);
 
       return [
         ...group,
@@ -140,13 +141,14 @@ function getRelationshipsParam({
  */
 export default function getDataParams(
   controller: Controller,
+  method: 'PATCH' | 'POST',
   includeID: boolean
 ): [string, ParameterLike] {
   let params = [getTypeParam(controller)];
 
   if (controller.hasModel) {
     params = [
-      getAttributesParam(controller),
+      getAttributesParam(controller, method),
       getRelationshipsParam(controller),
       ...params
     ];