Extract content from GitHub repos. #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Automated Parsing Preview 🤖Commit: Original Article | HTML Fixture | Parsed Content Preview Parsed JSON{
"title": "steventroughtonsmith/marzipanify",
"content": "<div><div><article class=\"markdown-body entry-content\">\n<p>marzipanify is an unsupported commandline tool to take an existing iOS Simulator binary (with minimum deployment target of iOS 12.0) and statically convert it and its embedded libraries & frameworks to run on macOS 10.14's UIKit runtime (Marzipan).</p>\n<p>This isn't a tool to automatically port your iOS app to the Mac — moreso something to get you up and running quickly.</p>\n<p>As an iOS Simulator app links against the iOS Simulator version of UIKit, it won't contain Marzipan-specific APIs like menu & window toolbar support. It's up to the user to know how to class-dump UIKitCore from /System/iOSSupport/System/Library/PrivateFrameworks and check for the macOS-specific UIKit APIs at runtime so the app can be a good Mac citizen.</p>\n<p>N.B. You will still need all the relevant Marzipan-related enabler steps (like disabling SIP & AMFI) before a converted app will run with your signature.</p>\n<h2><a id=\"user-content-usage\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#usage\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Usage</h2>\n<p><code>marzipanify MyApp.app|MyFramework.framework|MyBinary</code></p>\n<h2><a id=\"user-content-screenshot\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#screenshot\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Screenshot</h2>\n<p><a href=\"https://camo.githubusercontent.com/3b4a3c8b44a950b670dcbfb1e6eb86a57f9d5e6d/68747470733a2f2f686363646174612e73332e616d617a6f6e6177732e636f6d2f67685f6d61727a6970616e6966792e6a7067\"><img src=\"https://hccdata.s3.amazonaws.com/gh_marzipanify.jpg\" alt=\"screenshot\"></a></p>\n</article></div></div>",
"author": null,
"date_published": null,
"lead_image_url": "https://avatars0.githubusercontent.com/u/45212?s=400&v=4",
"dek": null,
"next_page_url": null,
"url": "https://github.com/steventroughtonsmith/marzipanify",
"domain": "github.com",
"word_count": 34,
"direction": "ltr",
"total_pages": 1,
"rendered_pages": 1
}
✅ All tests passed |
|
@benubois Do you think we could get It also seems like we could use |
I actually have a question about this. The generic extractor does get something for author. The docs mention that "it will fall back to its default generic extractor" if no matches are found from the selectors array, but that does not seem to be the case. Is there any way to force it to use the generic extractor for author rather than duplicating the logic in the custom extractor?
Sounds good! Done. |
So Mercury will fall back to the default generic extractor when it runs outside of the tests, but the tests pass the |
|
Yes! But then does the custom extractor need anything for author? The output from cli does indeed include it: {
"title": "steventroughtonsmith/marzipanify",
"content": "<div><div><article class=\"markdown-body entry-content\">\n<p>marzipanify is an unsupported commandline tool to take an existing iOS Simulator binary (with minimum deployment target of iOS 12.0) and statically convert it and its embedded libraries & frameworks to run on macOS 10.14's UIKit runtime (Marzipan).</p>\n<p>This isn't a tool to automatically port your iOS app to the Mac — moreso something to get you up and running quickly.</p>\n<p>As an iOS Simulator app links against the iOS Simulator version of UIKit, it won't contain Marzipan-specific APIs like menu & window toolbar support. It's up to the user to know how to class-dump UIKitCore from /System/iOSSupport/System/Library/PrivateFrameworks and check for the macOS-specific UIKit APIs at runtime so the app can be a good Mac citizen.</p>\n<p>N.B. You will still need all the relevant Marzipan-related enabler steps (like disabling SIP & AMFI) before a converted app will run with your signature.</p>\n<h2><a id=\"user-content-usage\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#usage\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Usage</h2>\n<p><code>marzipanify MyApp.app|MyFramework.framework|MyBinary</code></p>\n<h2><a id=\"user-content-screenshot\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#screenshot\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Screenshot</h2>\n<p><a href=\"https://camo.githubusercontent.com/3b4a3c8b44a950b670dcbfb1e6eb86a57f9d5e6d/68747470733a2f2f686363646174612e73332e616d617a6f6e6177732e636f6d2f67685f6d61727a6970616e6966792e6a7067\"><img src=\"https://hccdata.s3.amazonaws.com/gh_marzipanify.jpg\" alt=\"screenshot\"></a></p>\n</article></div></div><hr><h4>Page 2</h4><div><p id=\"ajax-error-message\" class=\"ajax-error-message\"> <svg class=\"octicon octicon-alert\" width=\"16\" height=\"16\"><path/></svg> You can’t perform that action at this time. </p><p class=\"js-stale-session-flash\"> <svg class=\"octicon octicon-alert\" width=\"16\" height=\"16\"><path/></svg> <span class=\"signed-in-tab-flash\">You signed in with another tab or window. <a href=\"https://github.com/steventroughtonsmith/marzipanify/pull/2\">Reload</a> to refresh your session.</span> <span class=\"signed-out-tab-flash\">You signed out in another tab or window. <a href=\"https://github.com/steventroughtonsmith/marzipanify/pull/2\">Reload</a> to refresh your session.</span> </p><template id=\"site-details-dialog\"> <details class=\"details-reset details-overlay details-overlay-dark lh-default text-gray-dark\"> <summary></summary> <details-dialog class=\"Box Box--overlay d-flex flex-column anim-fade-in fast\"> </details-dialog> </details>\n</template></div>",
"author": "steventroughtonsmith",
"date_published": "2019-03-04T12:37:07.000Z",
"lead_image_url": "https://avatars0.githubusercontent.com/u/45212?s=400&v=4",
"dek": null,
"next_page_url": "https://github.com/steventroughtonsmith/marzipanify/pull/2",
"url": "https://github.com/steventroughtonsmith/marzipanify",
"domain": "github.com",
"excerpt": "Convert an iOS Simulator app bundle to an iOSMac (Marzipan) one (Unsupported & undocumented, WIP) - steventroughtonsmith/marzipanify",
"word_count": 181,
"direction": "ltr",
"total_pages": 2,
"pages_rendered": 2
} |
🤖 Automated Parsing Preview 🤖Commit: Original Article | HTML Fixture | Parsed Content Preview Parsed JSON{
"title": "steventroughtonsmith/marzipanify",
"content": "<div><div><article class=\"markdown-body entry-content\">\n<p>marzipanify is an unsupported commandline tool to take an existing iOS Simulator binary (with minimum deployment target of iOS 12.0) and statically convert it and its embedded libraries & frameworks to run on macOS 10.14's UIKit runtime (Marzipan).</p>\n<p>This isn't a tool to automatically port your iOS app to the Mac — moreso something to get you up and running quickly.</p>\n<p>As an iOS Simulator app links against the iOS Simulator version of UIKit, it won't contain Marzipan-specific APIs like menu & window toolbar support. It's up to the user to know how to class-dump UIKitCore from /System/iOSSupport/System/Library/PrivateFrameworks and check for the macOS-specific UIKit APIs at runtime so the app can be a good Mac citizen.</p>\n<p>N.B. You will still need all the relevant Marzipan-related enabler steps (like disabling SIP & AMFI) before a converted app will run with your signature.</p>\n<h2><a id=\"user-content-usage\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#usage\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Usage</h2>\n<p><code>marzipanify MyApp.app|MyFramework.framework|MyBinary</code></p>\n<h2><a id=\"user-content-screenshot\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#screenshot\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Screenshot</h2>\n<p><a href=\"https://camo.githubusercontent.com/3b4a3c8b44a950b670dcbfb1e6eb86a57f9d5e6d/68747470733a2f2f686363646174612e73332e616d617a6f6e6177732e636f6d2f67685f6d61727a6970616e6966792e6a7067\"><img src=\"https://hccdata.s3.amazonaws.com/gh_marzipanify.jpg\" alt=\"screenshot\"></a></p>\n</article></div></div>",
"author": null,
"date_published": "2019-03-04T12:37:07.000Z",
"lead_image_url": "https://avatars0.githubusercontent.com/u/45212?s=400&v=4",
"dek": "Convert an iOS Simulator app bundle to an iOSMac (Marzipan) one (Unsupported & undocumented, WIP)",
"next_page_url": null,
"url": "https://github.com/steventroughtonsmith/marzipanify",
"domain": "github.com",
"word_count": 34,
"direction": "ltr",
"total_pages": 1,
"rendered_pages": 1
}
✅ All tests passed |
I like to include it whenever possible just for the sake of redundancy and because custom selectors are a more direct route to the data we want — it's saying "author is here" rather than "use heuristics to find author." I know it might seem a little tedious, but the idea is that it's faster, and if it does eventually fail, it can always fall back to the heuristics. |
🤖 Automated Parsing Preview 🤖Commit: Original Article | HTML Fixture | Parsed Content Preview Parsed JSON{
"title": "steventroughtonsmith/marzipanify",
"content": "<div><div><article class=\"markdown-body entry-content\">\n<p>marzipanify is an unsupported commandline tool to take an existing iOS Simulator binary (with minimum deployment target of iOS 12.0) and statically convert it and its embedded libraries & frameworks to run on macOS 10.14's UIKit runtime (Marzipan).</p>\n<p>This isn't a tool to automatically port your iOS app to the Mac — moreso something to get you up and running quickly.</p>\n<p>As an iOS Simulator app links against the iOS Simulator version of UIKit, it won't contain Marzipan-specific APIs like menu & window toolbar support. It's up to the user to know how to class-dump UIKitCore from /System/iOSSupport/System/Library/PrivateFrameworks and check for the macOS-specific UIKit APIs at runtime so the app can be a good Mac citizen.</p>\n<p>N.B. You will still need all the relevant Marzipan-related enabler steps (like disabling SIP & AMFI) before a converted app will run with your signature.</p>\n<h2><a id=\"user-content-usage\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#usage\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Usage</h2>\n<p><code>marzipanify MyApp.app|MyFramework.framework|MyBinary</code></p>\n<h2><a id=\"user-content-screenshot\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#screenshot\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Screenshot</h2>\n<p><a href=\"https://camo.githubusercontent.com/3b4a3c8b44a950b670dcbfb1e6eb86a57f9d5e6d/68747470733a2f2f686363646174612e73332e616d617a6f6e6177732e636f6d2f67685f6d61727a6970616e6966792e6a7067\"><img src=\"https://hccdata.s3.amazonaws.com/gh_marzipanify.jpg\" alt=\"screenshot\"></a></p>\n</article></div></div>",
"author": null,
"date_published": "2019-03-04T12:37:07.000Z",
"lead_image_url": "https://avatars0.githubusercontent.com/u/45212?s=400&v=4",
"dek": "Convert an iOS Simulator app bundle to an iOSMac (Marzipan) one (Unsupported & undocumented, WIP)",
"next_page_url": null,
"url": "https://github.com/steventroughtonsmith/marzipanify",
"domain": "github.com",
"word_count": 34,
"direction": "ltr",
"total_pages": 1,
"rendered_pages": 1
}
✅ All tests passed |
adampash
approved these changes
Mar 14, 2019
🤖 Automated Parsing Preview 🤖Commit: Original Article | HTML Fixture | Parsed Content Preview Parsed JSON{
"title": "steventroughtonsmith/marzipanify",
"content": "<div><div><article class=\"markdown-body entry-content\">\n<p>marzipanify is an unsupported commandline tool to take an existing iOS Simulator binary (with minimum deployment target of iOS 12.0) and statically convert it and its embedded libraries & frameworks to run on macOS 10.14's UIKit runtime (Marzipan).</p>\n<p>This isn't a tool to automatically port your iOS app to the Mac — moreso something to get you up and running quickly.</p>\n<p>As an iOS Simulator app links against the iOS Simulator version of UIKit, it won't contain Marzipan-specific APIs like menu & window toolbar support. It's up to the user to know how to class-dump UIKitCore from /System/iOSSupport/System/Library/PrivateFrameworks and check for the macOS-specific UIKit APIs at runtime so the app can be a good Mac citizen.</p>\n<p>N.B. You will still need all the relevant Marzipan-related enabler steps (like disabling SIP & AMFI) before a converted app will run with your signature.</p>\n<h2><a id=\"user-content-usage\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#usage\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Usage</h2>\n<p><code>marzipanify MyApp.app|MyFramework.framework|MyBinary</code></p>\n<h2><a id=\"user-content-screenshot\" class=\"anchor\" href=\"https://github.com/steventroughtonsmith/marzipanify#screenshot\"><svg class=\"octicon octicon-link\" width=\"16\" height=\"16\"><path/></svg></a>Screenshot</h2>\n<p><a href=\"https://camo.githubusercontent.com/3b4a3c8b44a950b670dcbfb1e6eb86a57f9d5e6d/68747470733a2f2f686363646174612e73332e616d617a6f6e6177732e636f6d2f67685f6d61727a6970616e6966792e6a7067\"><img src=\"https://hccdata.s3.amazonaws.com/gh_marzipanify.jpg\" alt=\"screenshot\"></a></p>\n</article></div></div>",
"author": null,
"date_published": "2019-03-04T12:37:07.000Z",
"lead_image_url": "https://avatars0.githubusercontent.com/u/45212?s=400&v=4",
"dek": "Convert an iOS Simulator app bundle to an iOSMac (Marzipan) one (Unsupported & undocumented, WIP)",
"next_page_url": null,
"url": "https://github.com/steventroughtonsmith/marzipanify",
"domain": "github.com",
"word_count": 34,
"direction": "ltr",
"total_pages": 1,
"rendered_pages": 1
}
✅ All tests passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps mercury find README content for GitHub repos. Currently you get this when using mercury on a repository:
Thanks!