Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add serverless prune plugin #79

Merged
merged 3 commits into from
Sep 20, 2019
Merged

chore: add serverless prune plugin #79

merged 3 commits into from
Sep 20, 2019

Conversation

WajeehZantout
Copy link
Contributor

@WajeehZantout WajeehZantout commented Sep 17, 2019 •
edited

This PR adds serverless-prune-plugin with some basic config for it in serverless.yml file:

custom:
  prune:
    automatic: true
    number: 5 # Number of versions to keep

It also fixes #64 by adding aws-sdk as dev dependency

adampash
adampash suggested changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@adampash adampash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @WajeehZantout! Just some copy tweaks.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@WajeehZantout WajeehZantout mentioned this pull request Sep 19, 2019
Closed
adampash
adampash approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@adampash adampash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@WajeehZantout WajeehZantout merged commit d1a46fe into master Sep 20, 2019
@WajeehZantout WajeehZantout deleted the chore-add-prune-plugin branch September 20, 2019 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adampash adampash adampash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yarn install --frozen-lockfile --non-interactive failed with code 1
2 participants
@WajeehZantout @adampash