test: Improve MRP volume tests

postlund · Jun 22, 2024 · a84774c · a84774c
1 parent 8080aaa
commit a84774c
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/tests/protocols/mrp/test_mrp_functional.py b/tests/protocols/mrp/test_mrp_functional.py
@@ -589,7 +589,7 @@ async def test_absolute_volume_features(self):
     async def test_volume_change(self):
         self.usecase.change_volume_control(available=True)
 
-        assert math.isclose(self.atv.audio.volume, 0.0)
+        await until(lambda: math.isclose(self.atv.audio.volume, 0.0))
 
         await until(
             lambda: self.atv.features.in_state(
@@ -612,13 +612,15 @@ async def _test_audio_volume_up_increases_volume(self):
             )
         )
         await self.atv.audio.set_volume(20.0)
-        assert math.isclose(self.atv.audio.volume, 20.0)
+        await until(lambda: math.isclose(self.atv.audio.volume, 20.0))
 
         await self.atv.audio.volume_up()
-        assert self.atv.audio.volume == round(20.0 + VOLUME_STEP * 100.0)
+        await until(lambda: self.atv.audio.volume == round(20.0 + VOLUME_STEP * 100.0))
 
         await self.atv.audio.volume_up()
-        assert self.atv.audio.volume == round(20.0 + 2 * VOLUME_STEP * 100.0)
+        await until(
+            lambda: self.atv.audio.volume == round(20.0 + 2 * VOLUME_STEP * 100.0)
+        )
 
     async def test_audio_volume_up_increases_volume_relative(self):
         self.usecase.change_volume_control(
@@ -641,13 +643,15 @@ async def _test_audio_volume_down_decreases_volume(self):
             )
         )
         await self.atv.audio.set_volume(20.0)
-        assert math.isclose(self.atv.audio.volume, 20.0)
+        await until(lambda: math.isclose(self.atv.audio.volume, 20.0))
 
         await self.atv.audio.volume_down()
-        assert self.atv.audio.volume == round(20 - VOLUME_STEP * 100.0)
+        await until(lambda: self.atv.audio.volume == round(20 - VOLUME_STEP * 100.0))
 
         await self.atv.audio.volume_down()
-        assert self.atv.audio.volume == round(20 - 2 * VOLUME_STEP * 100.0)
+        await until(
+            lambda: self.atv.audio.volume == round(20 - 2 * VOLUME_STEP * 100.0)
+        )
 
     async def test_audio_volume_down_decreases_volume_relative(self):
         self.usecase.change_volume_control(
@@ -668,7 +672,7 @@ async def _test_audio_volume_up_above_max(self):
             )
         )
         await self.atv.audio.set_volume(100.0)
-        assert math.isclose(self.atv.audio.volume, 100.0)
+        await until(lambda: math.isclose(self.atv.audio.volume, 100.0))
 
         # Should not yield a timeout
         await self.atv.audio.volume_up()
@@ -692,7 +696,7 @@ async def _test_audio_volume_down_below_zero(self):
             )
         )
         await self.atv.audio.set_volume(0.0)
-        assert math.isclose(self.atv.audio.volume, 0.0)
+        await until(lambda: math.isclose(self.atv.audio.volume, 0.0))
 
         # Should not yield a timeout
         await self.atv.audio.volume_down()