Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load AirPlay credentials via service #244

Merged
merged 1 commit into from Nov 7, 2019
Merged

Load AirPlay credentials via service #244

merged 1 commit into from Nov 7, 2019

Conversation

postlund
Copy link
Owner

@postlund postlund commented Nov 7, 2019 •
edited

This change moves AirPlay credentials to its service instead. API remains the same for now, will remove it when doing #240.

Also, this change replaces --device_credentials with:

  • --dmap-credentials
  • --mrp-credentials
  • --airplay-credentials

Fixes #227.

@postlund postlund added airplay AirPlay related issue scripts Bundled scripts, e.g. atvremote, atvscript, atvproxy labels Nov 7, 2019
@postlund postlund added this to the v0.4.0 milestone Nov 7, 2019
@postlund postlund self-assigned this Nov 7, 2019
@postlund postlund added this to In Progress in General via automation Nov 7, 2019
@coveralls
Copy link

coveralls commented Nov 7, 2019 •
edited

Coverage Status

Coverage increased (+0.03%) to 70.959% when pulling a83584c on airplay_creds into bf31d86 on master.

@postlund postlund merged commit 9328788 into master Nov 7, 2019
General automation moved this from In Progress to Done Nov 7, 2019
@postlund postlund deleted the airplay_creds branch November 7, 2019 12:20
@postlund postlund mentioned this pull request Nov 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@postlund postlund

Labels
airplay AirPlay related issue scripts Bundled scripts, e.g. atvremote, atvscript, atvproxy
Projects
No open projects
General
  
Done
Milestone
v0.4.0
Development

Successfully merging this pull request may close these issues.

Tidy up AirPlay credentials
2 participants
@postlund @coveralls