Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

how about add favicon.ico ? #459

Closed
isayme opened this issue May 21, 2018 · 6 comments
Closed

how about add favicon.ico ? #459

isayme opened this issue May 21, 2018 · 6 comments

Comments

@isayme
Copy link

isayme commented May 21, 2018

No description provided.

@javabrett
Copy link
Contributor

javabrett commented May 21, 2018 •
edited

Do you mean e.g. http://httpbin.org/favicon.ico (404)? Any image you have in-mind?

@isayme
Copy link
Author

isayme commented May 21, 2018

@javabrett yes.
I'm not a designer, maybe someone else could help to get one~~

@javabrett
Copy link
Contributor

https://favicon.io/?text=%3A%2F%2F%3F&shape=circle&fontFamily=Marck+Script&fontSize=64&fontColor=%23ff00bc&backgroundColor=%23000000

@isayme
Copy link
Author

isayme commented May 21, 2018

cool~

@rochacbruno
Copy link
Contributor

Create a new httpbin/static folder and put the icons there then change it here: https://github.com/requests/httpbin/blob/master/httpbin/templates/flasgger/index.html#L8

@isayme
Copy link
Author

isayme commented May 23, 2018

@javabrett could you help to make a PR ?

javabrett added a commit to javabrett/httpbin that referenced this issue May 29, 2018
@javabrett
Added a favicon.ico. Fixed postmanlabs#459.
b40dae3
javabrett added a commit to javabrett/httpbin that referenced this issue May 29, 2018
@javabrett
Added a favicon.ico. Fixed postmanlabs#459.
ea56eea
@javabrett javabrett mentioned this issue May 29, 2018
Merged
virgiliojr94 pushed a commit to virgiliojr94/httpbin-chat2desk that referenced this issue Jul 1, 2023
@javabrett
Added a favicon.ico. Fixed postmanlabs#459.
5dcf9cf
@rkvf01 rkvf01 mentioned this issue Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rochacbruno @javabrett @isayme