Merge pull request #3212 from yardenshoham/issues/3169

Fix `--color off` not being respected in summary table
postmanlabs · Mar 14, 2024 · cd81df4 · cd81df4
2 parents 0bcba86 + bb772e5
commit cd81df4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/reporters/cli/index.js b/lib/reporters/cli/index.js
@@ -426,12 +426,17 @@ _.assignIn(PostmanCLIReporter, {
      * @returns {Table} - The constructed collection run statistics table.
      */
     parseStatistics (stats, timings, transfers, options) {
-        var summaryTable;
+        var summaryTable,
+            style = { head: [] };
+
+        if (cliUtils.noTTY(options.color)) {
+            style.border = [];
+        }
 
         // create the summary table
         summaryTable = new Table({
             chars: options.disableUnicode && cliUtils.cliTableTemplateFallback,
-            style: { head: [] },
+            style: style,
             head: [E, 'executed', '  failed'],
             colAligns: ['right', 'right', 'right'],
             colWidths: [25]

diff --git a/test/cli/color-tty.test.js b/test/cli/color-tty.test.js
@@ -3,7 +3,7 @@ const fs = require('fs'),
 
 describe('CLI output', function () {
     // eslint-disable-next-line no-control-regex
-    const coloredOutput = /^[\u001b[0m]+newman/;
+    const coloredOutput = /\u001b/;
 
     describe('TTY', function () {
         // @todo: Change to assert colored output after https://github.com/shelljs/shelljs/pull/524 is released