Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies #3183

Merged

Conversation

KiraElric007
Copy link
Contributor

Sourced from postman-runtime's changelog.

7.36.0: date: 2023-11-18 new features: - >- GH-1336 Added support for fetching execution location context through script chores: - Updated dependencies

7.35.0: date: 2023-11-02 new features: - GH-1354 Added support for skipping request execution through script

7.34.0: date: 2023-10-19 new features: - GH-1340 Added support for ASAP authentication chores: - Updated dependencies

Sourced from postman-collection's changelog.

4.3.0: date: 2023-11-18 new features: - GH-1339 Added getPath method on Item chores: - Updated dependencies

@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a612fbe) 89.96% compared to head (396eed3) 89.96%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3183   +/-   ##
========================================
  Coverage    89.96%   89.96%           
========================================
  Files           21       21           
  Lines         1146     1146           
  Branches       347      347           
========================================
  Hits          1031     1031           
  Misses         115      115           
Flag Coverage Δ
cli 82.19% <ø> (ø)
integration 40.92% <ø> (ø)
library 58.55% <ø> (ø)
unit 74.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KiraElric007 KiraElric007 force-pushed the feat/update-postman-runtime-and-postman-collection branch 4 times, most recently from d773159 to 240dfe1 Compare December 12, 2023 08:02
@KiraElric007 KiraElric007 force-pushed the feat/update-postman-runtime-and-postman-collection branch from 240dfe1 to 96d3625 Compare December 12, 2023 11:52
@filipeandre
Copy link

filipeandre commented Dec 13, 2023

Hey, guys, the pr looks good. May you five me permissions to merge prs...
Looks like this feature of postman is getting old > 3 months and the non merge of this pr makes this project lag beind when it shoudn't, at least when the reason are the postman vendor libs.

Copy link

@vedkribhu vedkribhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good apart from skipped test.

@filipeandre
Copy link

filipeandre commented Dec 14, 2023

but the test skip is not related with the PR itself, but rather the node version.
have we a pr to fix the incompatibility with this test and node v20.10 ?

@KiraElric007
Copy link
Contributor Author

@vedkribhu The skipped test case, fails for timeout >= 7 ms for node versions < 20.10.0. This node PR adds a performance improvement in node v20.10.0 resulting in the test failing for timeout >= 4 ms. There seems to be a race condition that needs to be fixed in postman-runtime/postman-sandbox library.

The test case has been testing an edge case which passes, leaving out all the other cases when it actually fails. Since this is happening in develop as well, we can look into this in a separate PR. Let us not block this PR.

vedkribhu
vedkribhu previously approved these changes Dec 20, 2023
@vedkribhu vedkribhu self-requested a review December 20, 2023 07:08
@KiraElric007
Copy link
Contributor Author

I am attaching below screenshots of test case execution in different node versions with different timeout (All tests are run on develop branch [head commit]).

Test passing in node v16.10.0 with 5ms timeout:
Screenshot 2023-12-20 at 2 30 01 PM

Test failing in node v16.10.0 with 10ms timeout:
Screenshot 2023-12-20 at 2 28 17 PM

Test passing in node v20.10.0 with 3ms timeout:
Screenshot 2023-12-20 at 2 32 02 PM

Test failing in node v20.10.0 with 5ms timeout:
Screenshot 2023-12-20 at 2 31 11 PM

The above screenshot proves that the issue is existing in develop and not introduced because of this PR. We can deep dive into the root cause of this issue and fix it in a separate PR.

cc: @aman-postman

@codenirvana codenirvana changed the title Feat: Support for new apis exposed via postman runtime Updated dependencies Dec 27, 2023
@codenirvana codenirvana merged commit 944ae29 into develop Dec 27, 2023
7 checks passed
@codenirvana codenirvana deleted the feat/update-postman-runtime-and-postman-collection branch December 27, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants