Removed unnecessary options merging with each util function. #712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes issue where we were merging options when not needed due to all APIs now using SchemaPack which by default in it's constructor determines options to be used.
Ref:
openapi-to-postman/lib/schemapack.js
Line 61 in b4ef1dc
One of such instance was in
getRefObject()
which recursively resolves reference. This caused the merge operation to be done every single time a reference is resolved which is not required at all.Apart from this, in cases when there were circular reference in non-schema
$ref
, we were resolving them without recursion break points. We'll be now making sure that we resolve circular $ref correctly.We've removed all instance of merging of these options with default ones in
SchemaUtils.js
file and also fixed tests accordingly which were relying on this logic to be there.