Fixed issue where for certain path segments, collection generation failed. #723
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RCA
When the definition had certain path that contained same name as standard JS prototype properties, collection generation was failing with TypeError.
For example, path like
/constructor/v3/update-constructor
.We have following logic to determine if children already is present. Ideally, this should resolve to false while execution but because all JS object has a property called
constructor
. This was passing and further logic was not maintained correctly.Fix
Rather than directly accessing the properties, we'll now rely on
Object.hasOwnProperty()
function that makes sure it's true only when object has such own property.