Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing url encoding in multiple codegens due to back call to Url.getQueryString #506

Open
jpoehnelt opened this issue Jul 15, 2021 · 2 comments
Assignees
Labels
codegen good first issue Good for newcomers

Comments

@jpoehnelt
Copy link
Contributor

Url.getQueryString({encode: true}) is no longer supported (https://github.com/postmanlabs/postman-collection/pull/1198/files#diff-0267b663041b4094bb4802be9641a818f458a54127910a9126e61ae9d499232eL313).

This leads to urls that are not properly encoded in the following codegens:

  • curl
  • swift
  • java-unirest

https://github.com/postmanlabs/postman-code-generators/search?q=getQueryString

@jpoehnelt
Copy link
Contributor Author

It seems many other codegens use the request.url.toString() pattern.

@jpoehnelt
Copy link
Contributor Author

seems to be mostly a local issue where i had postman-collection@4.0. downgrading to 3.x fixed the issue for now. this still needs to be updated though.

@webholik webholik self-assigned this Jul 20, 2021
@VShingala VShingala added the good first issue Good for newcomers label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codegen good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants