Swift Language Update #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @umeshp7, are you able to take a look at this one? |
|
Hey @maxxfrazer, we've made some changes in Swift codegen. Can you use the latest package once and see if we still require this PR? If yes, could you please resolve the conflicts in the file? |
|
Looks like most of this is still relevant IMO. Will fix conflicts and make sure it all looks good; will update you after. |
|
@SahilChoudhary22 please review these changes once as you recently worked on Swift changes. |
|
@dhwaneetbhatt @SahilChoudhary22 appreciate it! |
|
I have verified the SwiftGen works correctly as expected in a live code editor. Merging this PR. Thank you for contributing @maxxfrazer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continue.[[String : Any]]-> [[String: Any]]` can be found here