Skip to content

Commit

Permalink
Updated CHANGELOG.yaml and fixed browser integration test failure
Browse files Browse the repository at this point in the history
  • Loading branch information
Prashant Shubham committed Oct 5, 2020
1 parent 1fcd39a commit c3b92c4
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
master:
date: 2020-10-05
chores:
- Added integration test for large file upload

7.26.6:
date: 2020-09-16
chores:
Expand Down
6 changes: 4 additions & 2 deletions test/integration/file-uploads/request-body.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -650,13 +650,14 @@ describe('file upload in request body', function () {
});
});

describe('should upload large files correctly', function () {
(IS_BROWSER ? describe.skip : describe)('should upload large files correctly', function () {
var testUploadFile = 'test/fixtures/upload-file-large.json';

afterEach(function () {
sh.rm('-rf', testUploadFile);
});

// eslint-disable-next-line mocha/no-sibling-hooks
before(function (done) {
this.enableTimeouts(false);
if (IS_DARWIN) {
Expand Down Expand Up @@ -689,6 +690,7 @@ describe('file upload in request body', function () {
});
});

// eslint-disable-next-line mocha/no-identical-title
it('should complete the run', function () {
expect(testrun).to.be.ok;
sinon.assert.calledOnce(testrun.start);
Expand All @@ -697,7 +699,7 @@ describe('file upload in request body', function () {
sinon.assert.callCount(testrun.request, 1);
});

it('should upload the file correctly', function () {
it('should upload the large file correctly', function () {
sinon.assert.calledWith(testrun.request.getCall(0), null);

var resp = JSON.parse(testrun.response.getCall(0).args[2].stream.toString());
Expand Down

0 comments on commit c3b92c4

Please sign in to comment.