Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for large iteration count #956

Merged
merged 5 commits into from Jan 21, 2020

Conversation

coditva
Copy link
Member

@coditva coditva commented Jan 20, 2020

Add a test that check if run creation is successful for large iteration count. Not checking if iterations are run because it'll take a looong time.

@codecov
Copy link

codecov bot commented Jan 20, 2020

Codecov Report

Merging #956 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #956      +/-   ##
===========================================
+ Coverage    90.83%   90.83%   +<.01%     
===========================================
  Files           42       42              
  Lines         2378     2379       +1     
  Branches       670      671       +1     
===========================================
+ Hits          2160     2161       +1     
  Misses         218      218
Flag Coverage Δ
#integration 79.94% <100%> (-0.04%) ⬇️
#legacy 58.3% <100%> (+0.01%) ⬆️
#unit 47.7% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
lib/requester/core.js 91.57% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6dd818...cf86a94. Read the comment docs.

Copy link
Member

@codenirvana codenirvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is should be a unit test.
Assert on:

  • run.state.data
  • run.options.iterationCount

codenirvana
codenirvana previously approved these changes Jan 21, 2020
@coditva
Copy link
Member Author

coditva commented Jan 21, 2020

Force pushed to restart Travis build.

@codenirvana codenirvana merged commit ce2fbeb into develop Jan 21, 2020
@codenirvana codenirvana deleted the chore/test-large-iteration-count branch January 21, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants