Quick fix for PMJSON on Linux #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoa, SIL verification failure for stuff to do with a private or hidden symbol? That's a pretty wacky error. I would really prefer not to make all that stuff public, though, so I'll see if I can figure out an alternative solution. |
|
I rewrote your PR because I didn't want to expose that stuff publicly. The visibility issues were actually issues with Thanks for the contribution! |
|
I also released v2.0.2 for this fix, so you can target that with SPM. |
|
Great, thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've integrated PMJSON to parse big JSON file on a Kitura project and recognised that PMJSON 2.0.1 wouldn't compile on the ibmcom/swift-ubuntu docker image (for example). On Linux, the
DecimalPaceholderobject couldn't be compared (thus the==function), a few methods couldn't be called because there are changes to swift that preventfileprivateorprivatemethods to be called. Lastly I had to add some!for thestrtodcall.It works for me now, maybe you could review the changes or test in your own branch. Thanks for your great work!
This change is