Migrated codebase to swift 3.0 (Xcode 8 beta 2) #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! I'll review it shortly. |
lilyball
pushed a commit
that referenced
this pull request
Jul 8, 2016
Migrated codebase to swift 3.0 (Xcode 8 beta 2)
|
Looks good, thanks! I've merged it into a new |
|
@kballard Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kballard
Here's a fix for #10
Most of the migration work was done automatically with the Xcode migration tool. All I had to do is to play around with
NSKeyValueChangeKeyandunsafeDowncast.All tests pass on both OSX and iOS.
I would suggest to merge this code in a new branch
swift-3.0to keep the code separate until Xcode 8 is released.Let me know if you have any questions!
This change is