Updated podspec to includes sub spec for just ObjC #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solves this issue #6 |
| end | ||
|
|
||
| s.subspec 'Swift' do |ss| | ||
| ss.ios.deployment_target = '8.0' |
There was a problem hiding this comment.
Why does this re-declare the deployment target when the parent spec declares it already?
There was a problem hiding this comment.
Good spot shouldn't be needed.
|
@kballard That should be it sorted now 👍 |
lilyball
added a commit
that referenced
this pull request
Feb 25, 2016
Updated podspec to includes sub spec for just ObjC
|
Thanks! |
|
@kballard no problem! Can you push the new pod spec to the central pods repo? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing pod spec brings in the objective-c files and swift. If using this pods in a project which includes static libs then the pod can not be used as it contains swift and there has to be a framework.
This PR includes a 2 subspaces one for ObjC and one for Swift.
Example usage just for ObjC