New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use feature gates #177

Open
blt opened this Issue Jan 9, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@blt
Collaborator

blt commented Jan 9, 2017

Lua is an obligatory dependency of cernan as of this writing. Not all cernan deployments will wish to use the lua programmable filters but still pay the build-time cost for this. Similar story for firehose – which pulls in rusuto – and any of the other sinks.

We should go all-in on feature flags. There are two issues with doing so. First is configuration. As of this writing we'll have to do macro hacks to get our configuration parsing under control. Second is matrix testing cernan across its features. Integration tests are not able to toggle features.

@blt blt added this to the 0.6.0 - EVA milestone Jan 9, 2017

@blt blt changed the title from Put Lua programmable filters behind a feature gate to Use feature gates May 13, 2017

@blt blt modified the milestones: 0.6.0 - EVA , 0.7.0 - rendezvous May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment