Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to python3 #2

Merged
merged 1 commit into from
Jan 2, 2021
Merged

Transition to python3 #2

merged 1 commit into from
Jan 2, 2021

Conversation

hellcp
Copy link
Contributor

@hellcp hellcp commented Apr 3, 2020

No description provided.

@hellcp
Copy link
Contributor Author

hellcp commented Apr 4, 2020

It seems attachments aren't actually getting uploaded or pastes with attachments aren't saved. I will have a look at how to fix that later

@@ -66,10 +66,10 @@
# This is only relevant if USE_ENCRYPTED_IDS above is True. If not, this config parameter can be ignored.
# It is recommended, but not strictly required, for you to replace the string below with the output of os.urandom(32),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.urandom(32) will not work, since bytes and str will have different len after .encode() and .decode() (and AES requires constant key len dividable by 2^4)

@@ -1,6 +1,6 @@
[flake8]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flake8 tests will require code refactor to be honest

@Conan-Kudo
Copy link

@hellcp There is one test failure:

======================================================================
ERROR: test_paste_attachment (test_views.test_paste.TestPaste)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/postmodern-paste/postmodern-paste/tests/test_views/test_paste.py", line 105, in test_paste_attachment
    self.assertEqual('file contents', resp.get_data())
AttributeError: 'tuple' object has no attribute 'get_data'
----------------------------------------------------------------------

@hellcp
Copy link
Contributor Author

hellcp commented Apr 6, 2020

@hellcp There is one test failure:

Yeah, it's an issue with attachments overall, something's very broken

@Conan-Kudo Conan-Kudo merged commit 5289309 into postmodern-paste:master Jan 2, 2021
@Conan-Kudo
Copy link

I'm merging this so we have something, we can fix attachments later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants