Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading plugins in console mode (closes #286) #289

Closed
wants to merge 1 commit into from
Closed

Add loading plugins in console mode (closes #286) #289

wants to merge 1 commit into from

Conversation

rezwyi
Copy link
Contributor

@rezwyi rezwyi commented Apr 5, 2014

@nolman
Copy link
Member

nolman commented Apr 15, 2014

I think that plugins and the console are a bit of an odd couple. People typically register things that run via an EventMachine callback (timeout/periodic timer) however with the way the console is implemented these things will not run unless you yield control back to the Reactor (Ex EM::HttpRequest).

I am hesitant about adding this because it really won't work in an intuitive way unless we fix the REPL to play well with EM.

@rezwyi rezwyi closed this Apr 16, 2014
@rezwyi rezwyi reopened this Apr 16, 2014
@rezwyi
Copy link
Contributor Author

rezwyi commented Apr 16, 2014

You are right. Initialize plugins in console mode without fixed REPL is a bad idea.

@rezwyi rezwyi closed this Apr 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants