Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): use native vue-router types #418

Merged
merged 20 commits into from
Jun 21, 2024
Merged

Conversation

posva
Copy link
Owner

@posva posva commented Jun 12, 2024

BREAKING CHANGE: TODO: write changelog once the changes are confirmed

  • Remove the need of vue-router/auto
  • Move all typed versions from 'unplugin-vue-router/types' to 'vue-router'

Update docs

BREAKING CHANGE: TODO: write changelog once the changes are confirmed
Copy link

cloudflare-pages bot commented Jun 12, 2024

Deploying unplugin-vue-router with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f8a5a7
Status: ✅  Deploy successful!
Preview URL: https://8f90f2f7.unplugin-vue-router.pages.dev
Branch Preview URL: https://refactor-vue-router-types.unplugin-vue-router.pages.dev

View logs

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 69.74359% with 118 lines in your changes missing coverage. Please review.

Project coverage is 73.29%. Comparing base (7b5f9b8) to head (5f8a5a7).

Files Patch % Lines
src/index.ts 0.00% 54 Missing ⚠️
src/core/vite/index.ts 0.00% 23 Missing ⚠️
src/core/definePage.ts 87.50% 14 Missing ⚠️
src/data-loaders/entries/index.ts 0.00% 9 Missing and 1 partial ⚠️
src/core/context.ts 86.66% 6 Missing ⚠️
src/codegen/generateRouteRecords.ts 0.00% 5 Missing ⚠️
src/codegen/vueRouterModule.ts 0.00% 4 Missing ⚠️
src/codegen/generateDTS.ts 0.00% 1 Missing ⚠️
src/data-loaders/defineVueFireLoader.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
- Coverage   73.99%   73.29%   -0.71%     
==========================================
  Files          33       34       +1     
  Lines        5623     5767     +144     
  Branches      548      581      +33     
==========================================
+ Hits         4161     4227      +66     
- Misses       1453     1530      +77     
- Partials        9       10       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

socket-security bot commented Jun 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/vue-router@4.4.0-alpha.3 environment Transitive: eval +5 4.88 MB posva

🚮 Removed packages: npm/vue-router@4.3.3

View full report↗︎

@posva posva merged commit 5f8a5a7 into main Jun 21, 2024
10 of 11 checks passed
@posva posva deleted the refactor/vue-router-types branch June 21, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant