Skip to content

Commit

Permalink
Commit d1566ea exposed a broken test: The timeuntil filter never rais…
Browse files Browse the repository at this point in the history
…ed an error in the first place.

I removed the test completely (at least as long as we're only relying on Django behavior to raise the errors for us). But as I noted elsewhere, maybe Coffin shouldn't be in the business of trying to enforce additional strict error checking on top of Django's builtin stuff in the first place.
  • Loading branch information
miracle2k committed Mar 10, 2010
1 parent 0df8f0b commit 5c70854
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions tests/test_defaultfilters.py
Expand Up @@ -50,6 +50,4 @@ def test_date_stuff():
# this is a particular case where it makes sense.
for f in ('date', 'time', 'timesince', 'timeuntil'):
assert r('a{{ d|%s }}b' % f) == 'ab'
assert r('a{{ d|%s }}b' % f, {'d': None}) == 'ab'
# given an empty string though (wrong type), an error would be raced
assert_raises(Exception, env.from_string('a{{ d|%s }}b' % f).render, {'d': ''})
assert r('a{{ d|%s }}b' % f, {'d': None}) == 'ab'

0 comments on commit 5c70854

Please sign in to comment.