Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX isFixed change detection #247

Merged
merged 1 commit into from
Feb 6, 2020
Merged

Conversation

birdspider
Copy link
Contributor

@birdspider birdspider commented Feb 5, 2020

should fix #233 and #226

I had to edit ExampleApp.vue due to not being able to "test" the threshold since it was passed as string

@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #247 into master will decrease coverage by 5.24%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage    64.7%   59.45%   -5.25%     
==========================================
  Files           2        2              
  Lines          34       37       +3     
  Branches        5        7       +2     
==========================================
  Hits           22       22              
- Misses         12       15       +3
Impacted Files Coverage Δ
src/components/vue-fixed-header.ts 62.85% <0%> (-5.9%) ⬇️

Copy link
Owner

@potato4d potato4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

LGTM

thank you

@potato4d potato4d merged commit de869f7 into potato4d:master Feb 6, 2020
@potato4d
Copy link
Owner

potato4d commented Feb 6, 2020

@all-contributors please add @birdspider for bug

@allcontributors
Copy link
Contributor

@potato4d

I've put up a pull request to add @birdspider! 🎉

@birdspider birdspider deleted the fix-223 branch February 6, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improving scroll handling and isFixed change detection
2 participants