Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets are not preloading properly #7

Closed
potatoeggy opened this issue Jul 24, 2021 · 2 comments · Fixed by #44
Closed

Assets are not preloading properly #7

potatoeggy opened this issue Jul 24, 2021 · 2 comments · Fixed by #44
Labels
design There is something ugly or doesn't match with the original help wanted Extra attention is needed

Comments

@potatoeggy
Copy link
Owner

On the initial visit, the background takes a bit to load in — this is acceptable. What is not acceptable is that the initial videos and character backgrounds slide in.

All resources should be prefetched if possible (prefetch while the video plays?).

Alternatively, use a CDN.

@potatoeggy potatoeggy added the design There is something ugly or doesn't match with the original label Jul 24, 2021
@potatoeggy
Copy link
Owner Author

Character background issues have been resolved by waiting for them to fully load before displaying any animations.

@potatoeggy potatoeggy mentioned this issue Aug 18, 2021
@potatoeggy potatoeggy added this to the 1.0 milestone Oct 5, 2021
@potatoeggy potatoeggy removed this from the 1.0 milestone Dec 15, 2021
@potatoeggy
Copy link
Owner Author

Assets can be preloaded at the following stages:

  • the welcome (main) screen cannot be preloaded, but can be hidden behind a loading screen like https://genshin.thekima.com
  • other banners/selected headers can be preloaded in the WishBanners screen
  • video should be preloaded while on WishBanners (or during the intro)
    • the ItemObtainOverlay can also be preloaded at this time
  • featured character icons and their backgrounds can be optionally preloaded in WishBanners
  • roll splash art can be preloaded during video playback

@potatoeggy potatoeggy added the help wanted Extra attention is needed label Jan 11, 2022
potatoeggy added a commit that referenced this issue Feb 2, 2022
Resolves #7. Prefetches the following:

 - Banner headers/images
 - Wish videos
 - Splash art and element art
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design There is something ugly or doesn't match with the original help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant