Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to New Setter-based RSA PKey API #7

Merged

Conversation

waynerobinson
Copy link
Contributor

The accessors on setting PKey elements inOpenSSL::PKey::RSA have been deprecated in Ruby 2.4+.

Move to newer method-based setters.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 88.507% when pulling 87e3546 on AllMyFunds:update_deprecrated_pkey_interface into 8b8fa70 on potatosalad:master.

@waynerobinson
Copy link
Contributor Author

The Travis tests seem to run with the rather ancient version of Ruby of 2.3.1p112, hence the failures. Not sure why the coverage was decreased given the existing test cases cover the same methods.

By the way, as of Ruby 2.5, the JOSE library doesn't work at all as these accessors have been deprecated entirely.

@potatosalad
Copy link
Owner

@waynerobinson Thanks for submitting this! I'll take a look into this sometime this week.

@Firefishy
Copy link

@potatosalad @waynerobinson Any progress getting this fix merged?

@Firefishy
Copy link

Build with Ruby 2.5 seems ok: https://travis-ci.org/potatosalad/ruby-jose/builds/404606921

@Firefishy
Copy link

Firefishy commented Aug 23, 2018

JOSE v1.1.2 release also broken on ruby >=2.4.4

@rodxavier
Copy link

Can this be merged and released @potatosalad?

@potatosalad potatosalad merged commit 87e3546 into potatosalad:master Sep 21, 2018
@potatosalad
Copy link
Owner

@Firefishy @rodxavier Released as part of jose 1.1.3

@waynerobinson Thanks for your contribution!

@rodxavier
Copy link

Thanks so much @potatosalad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants