gpm get to only get packages
#77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… correct version but not install them
Does some file descriptor magic to pass things from one function to the other and still being able to output "normal" output to the user on stdout and error output on stderr.
|
Huh. Well, the tests pass in travis ¯_(ツ)_/¯ |
|
Thank you so much for picking this up! I am sorry I couldn't do better. My bash skills are pretty limited. |
|
Great! Saved me the trouble, thank you both @eatonphil and @foca! ❤️ 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on the work of @eatonphil on #76. Splits
set_dependenciesintoget_dependenciesandinstall_dependencies.In order to maintain output (and correct usage of stdout and stderr) does some file descriptor juggling, using fd=3 to pass around information from either functions for things that should be output to the user.
I'm seeing a couple tests failing locally, but I think it's due to changes in redigo that are breaking the tests. This is working from my tests using my dev version to get / install packages :)
cc @pote