Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

email validation fix #119

Conversation

vinodhrajamuralidharan
Copy link

  • - existing validation rule accepts the email without domain (test@gmail) - So, I've updated the rule.

Closes # .

Changes proposed in this pull request

VinodhRaja Muralidharan added 2 commits January 23, 2017 09:54
@brandynbennett
Copy link
Contributor

Can you please add tests and update the documentation.

@poteto
Copy link
Owner

poteto commented Jan 27, 2017

Hi, thanks for the PR. I would recommend creating your own email validator in your project instead. The reason for this is that I am uncertain what the entire range of valid emails is under this new regex, and I think front end validation of emails should be very light.

@gczene
Copy link

gczene commented Feb 20, 2017

@poteto the current one is too open, e.g.

  • email@domain
  • 'email@123'
  • -@1
    are even accepted. Actually we had to provide our own regex (it is in this PR), but our suggestion with @vinodhrajamuralidharan to double check it .

Thanks

@poteto
Copy link
Owner

poteto commented Feb 21, 2017

Please see #120 (comment)

@poteto poteto closed this Feb 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants