Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move around tests and use new qunit apis #316

Merged
merged 2 commits into from Sep 22, 2018
Merged

Conversation

snewcomer
Copy link
Collaborator

No description provided.

@snewcomer snewcomer self-assigned this Sep 11, 2018
@snewcomer
Copy link
Collaborator Author

snewcomer commented Sep 11, 2018

@nickschot is this the same error you were seeing? My initial check was just to move it out of a

TypeError: (0 , _emberMetal.get)(...).getURL is not a function

If so, we might have to chalk this up as one other case where Relay has gone wrong for us.

Ref #315

@nickschot
Copy link

nickschot commented Sep 11, 2018

That is the error that's thrown in the failing test (#314) indeed. See: https://travis-ci.org/poteto/ember-changeset/jobs/426214417#L607

I do not see this error in my ember-bootstrap form (w/ changeset 1.5.0 & ember-model-select). Could be that it's caught somewhere.

I think you also lost some text, what's that second sentence?

@snewcomer snewcomer merged commit 669246e into master Sep 22, 2018
@snewcomer snewcomer deleted the sn/move-around-tests branch September 22, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants