Parse remote #13
Merged
Parse remote #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is awesome, ty so much for contributing! |
poteto
reviewed
Mar 19, 2017
lib/process-diff.js
Outdated
| @@ -46,6 +46,16 @@ const extractLocation = ((location) => { | |||
| }); | |||
| }); | |||
|
|
|||
| const extractRemoteAvailable = ((location) => { | |||
| let locations = location | |||
There was a problem hiding this comment.
this could be a little simpler:
let remoteRegex = /remote/i
let remoteOk = remoteRegex.exec(location);
return !!remoteOk;
|
@poteto I rebased and squashed the fixup commit |
|
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #12.
I haven't had a chance to get airtable setup and test this so this may not be quite right, let me know if there are any issues. Thanks for putting this project together!