Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check composer implementation #6

Open
potofcoffee opened this issue Dec 28, 2018 · 1 comment
Open

Check composer implementation #6

potofcoffee opened this issue Dec 28, 2018 · 1 comment
Assignees
@potofcoffee
Labels
enhancement
Milestone
v1.0

Comments

@potofcoffee
Copy link
Owner

As of now, PULPIT relies heavily on third-party dependencies pulled in via composer. There are some concerns to be taken care of, however:

  • Provide a proper means to execute composer install on plugin install.
  • Check whether composer update correctly works through the plugin settings page.
  • Check versioning/namespacing concerns, such as mentioned here:

https://wptavern.com/a-narrative-of-using-composer-in-a-wordpress-plugin
@potofcoffee potofcoffee self-assigned this Dec 28, 2018
@potofcoffee potofcoffee added this to the v1.0 milestone Dec 28, 2018
@potofcoffee
Copy link
Owner Author

https://www.getinstance.com/including-classes-in-wordpress-plugins-using-composer-and-autoload/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@potofcoffee potofcoffee

Labels
enhancement
Projects
None yet
Milestone
v1.0
Development

No branches or pull requests
1 participant
@potofcoffee