Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Show obselete strings when in array #21

Closed
marvinschroeder opened this issue Feb 1, 2016 · 1 comment
Closed

[REQUEST] Show obselete strings when in array #21

marvinschroeder opened this issue Feb 1, 2016 · 1 comment

Comments

@marvinschroeder
Copy link

Would be great to show obselete strings when they are nested in an array.

We have something like

return array (
'buttons' => [
'save' => 'Save',
'change' => 'Change',
]
);

So if the key app.buttons.change is obsolete, your package recognizes this, prints it in the command line interface (1 obsolete strings (can be deleted manually in the generated file)) and when the file is created, nothing shows up after the obsolete strings section (comment).

If it isn't possible or easy to specially mark the obsolete strings directly in the array, it would be great to output the specific keys in the obsolete strings section. In that case we could search the found keys ourselves in the arrays and remove them.

@potsky
Copy link
Owner

potsky commented Feb 1, 2016

It is a old problem that should be fixed.

If the obsolete key is a root key (like your buttons key for example), the key will be set in the obsolete array at the beginning of the file.

If the obsolete key is a child key, it will not be included because I cannot redefine the parent key of course which should now contain valid and obsolete keys...

A workaround could be setting an LLH_obsolete array for example which should be able to include all child and root obsolete keys.

Will be done in version 2.x.2 !

potsky added a commit that referenced this issue Feb 2, 2016
@potsky potsky closed this as completed in 31c53c2 Feb 2, 2016
potsky added a commit that referenced this issue Feb 2, 2016
potsky added a commit that referenced this issue Feb 2, 2016
potsky added a commit that referenced this issue Feb 2, 2016
potsky added a commit that referenced this issue Feb 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants